Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 814833008: dart2js: rename Elements.isErroneousElement to Elements.isErroneous. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: rename Elements.isErroneousElement to Elements.isErroneous. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
Peter will most likely delete the function soon, but until then I prefer this name.
5 years, 11 months ago (2015-01-15 16:15:15 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-16 08:23:56 UTC) #3
floitsch
5 years, 11 months ago (2015-01-16 08:58:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698