Issue 814533005: Incrementally resolve users of a changed method.

Issue 814533005: Incrementally resolve users of a changed method. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Incrementally resolve users of a changed method. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42515

Patch Set 1 #

Total comments: 5

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+238 lines, -144 lines)			Patch
M	pkg/analyzer/lib/src/generated/element_resolver.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	22 chunks	+175 lines, -106 lines	4 comments	Download
M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	2 chunks	+7 lines, -0 lines	1 comment	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	11 chunks	+55 lines, -36 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/814533005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/814533005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode638 pkg/analyzer/lib/src/generated/incremental_resolver.dart:638: classElement.methods.removeWhere((e) => identical(e, element)); Do we really need ...

6 years ago (2014-12-19 15:03:29 UTC) #3

scheglov

Committed patchset #1 (id:1) manually as 42515 (presubmit successful).

6 years ago (2014-12-19 17:42:19 UTC) #4

scheglov

6 years ago (2014-12-19 17:43:05 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/814533005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/814533005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:638:
classElement.methods.removeWhere((e) => identical(e, element));
On 2014/12/19 15:03:29, Brian Wilkerson wrote:
> Do we really need to iterate over all of the elements?

No, we don't.
But we cannot use just List.remove(), because it uses == instead of identical.
I created a helper method to stop iterating after the first identical element.

https://codereview.chromium.org/814533005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:1056:
entry.getValueInLibrary(DartEntry.RESOLUTION_ERRORS, librarySource);
On 2014/12/19 15:03:29, Brian Wilkerson wrote:
> FWIW the error access could also be moved into _shiftErrors.

Done.

Expand Messages | Collapse Messages