Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 814453003: Ensure shutdown is always called (Closed)

Created:
6 years ago by Brian Wilkerson
Modified:
6 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M pkg/analysis_server/lib/driver.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years ago (2014-12-17 17:04:37 UTC) #2
Paul Berry
lgtm
6 years ago (2014-12-17 17:35:32 UTC) #3
Brian Wilkerson
6 years ago (2014-12-17 18:16:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698