Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 814343004: First step in eliminating —enable_async flag (Closed)

Created:
5 years, 11 months ago by hausner
Modified:
5 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, devoncarew
Visibility:
Public.

Description

First step in eliminating —enable_async flag Switch default value of enable-async to true, and remove the flag from test source code. Next step is to remove the flag altogether R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/async_control_structures_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/async_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/language/await_backwards_compatibility_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/await_exceptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_for_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/await_future_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_nonfuture_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_regression_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/await_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/vm/optimized_await_regress_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 11 months ago (2015-01-07 18:16:41 UTC) #2
Ivan Posva
LGTM -ip
5 years, 11 months ago (2015-01-07 18:20:12 UTC) #3
hausner
5 years, 11 months ago (2015-01-07 19:43:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698