Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 814013002: Support functions for testing multiple files. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, lukechurch, kasperl
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Support functions for testing multiple files. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42456

Patch Set 1 #

Total comments: 4

Patch Set 2 : Indentation. #

Patch Set 3 : Merged with r42455. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M dart/tests/try/poi/source_update.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M dart/tests/try/poi/source_update_test.dart View 1 2 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
I think this could be useful for Fletch as well.
6 years ago (2014-12-18 09:42:49 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/814013002/diff/1/dart/tests/try/poi/source_update.dart File dart/tests/try/poi/source_update.dart (right): https://codereview.chromium.org/814013002/diff/1/dart/tests/try/poi/source_update.dart#newcode43 dart/tests/try/poi/source_update.dart:43: /// Returns [files] split into mulitple named files. ...
6 years ago (2014-12-18 11:19:46 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/814013002/diff/1/dart/tests/try/poi/source_update_test.dart File dart/tests/try/poi/source_update_test.dart (right): https://codereview.chromium.org/814013002/diff/1/dart/tests/try/poi/source_update_test.dart#newcode50 dart/tests/try/poi/source_update_test.dart:50: JSON.encode(splitFiles(r""" On 2014/12/18 11:19:46, Johnni Winther ...
6 years ago (2014-12-18 11:35:13 UTC) #4
ahe
Committed patchset #3 (id:40001) manually as 42456 (presubmit successful).
6 years ago (2014-12-18 11:36:10 UTC) #5
ahe
6 years ago (2014-12-18 11:38:53 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/814013002/diff/1/dart/tests/try/poi/source_up...
File dart/tests/try/poi/source_update.dart (right):

https://codereview.chromium.org/814013002/diff/1/dart/tests/try/poi/source_up...
dart/tests/try/poi/source_update.dart:43: /// Returns [files] split into
mulitple named files. The keys in the returned
On 2014/12/18 11:19:46, Johnni Winther wrote:
> mulitple -> multiple

Whoops. Forgot this. I'll add this change to CL 809363002.

Powered by Google App Engine
This is Rietveld 408576698