Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 813873008: dart2js: Store mapTypeToInterceptor in embedded global. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
ahe, sra1
CC:
reviews_dartlang.org, zarah, ahe
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Store mapTypeToInterceptor in embedded global. R=ahe@google.com, sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=42692

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove "dynamic" type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/interceptors.dart View 1 2 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
floitsch
5 years, 11 months ago (2015-01-07 15:49:27 UTC) #2
sra1
lgtm
5 years, 11 months ago (2015-01-08 01:50:23 UTC) #3
ahe
lgtm https://codereview.chromium.org/813873008/diff/1/sdk/lib/_internal/compiler/js_lib/interceptors.dart File sdk/lib/_internal/compiler/js_lib/interceptors.dart (right): https://codereview.chromium.org/813873008/diff/1/sdk/lib/_internal/compiler/js_lib/interceptors.dart#newcode200 sdk/lib/_internal/compiler/js_lib/interceptors.dart:200: dynamic get mapTypeToInterceptor { Why add "dynamic"? It ...
5 years, 11 months ago (2015-01-08 08:43:08 UTC) #5
floitsch
5 years, 11 months ago (2015-01-08 13:30:10 UTC) #6
floitsch
5 years, 11 months ago (2015-01-08 13:30:10 UTC) #7
floitsch
https://codereview.chromium.org/813873008/diff/1/sdk/lib/_internal/compiler/js_lib/interceptors.dart File sdk/lib/_internal/compiler/js_lib/interceptors.dart (right): https://codereview.chromium.org/813873008/diff/1/sdk/lib/_internal/compiler/js_lib/interceptors.dart#newcode200 sdk/lib/_internal/compiler/js_lib/interceptors.dart:200: dynamic get mapTypeToInterceptor { On 2015/01/08 08:43:08, ahe wrote: ...
5 years, 11 months ago (2015-01-08 13:30:29 UTC) #8
floitsch
5 years, 11 months ago (2015-01-08 13:31:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42692 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698