Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 813503005: Make mirror_in_static_init_test a multitest (Closed)

Created:
5 years, 11 months ago by sigurdm
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, koda, rmacnak, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Improve mirror_in_static_init_test Make it a multitest. Fix a syntax error. Also move it to lib/mirrors/ - it will then automatically be skipped by dart2dart. BUG=dartbug.com/22071 R=floitsch@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42992

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -29 lines) Patch
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/language/mirror_in_static_init_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
A + tests/lib/mirrors/mirror_in_static_init_test.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sigurdm
5 years, 11 months ago (2015-01-19 14:42:16 UTC) #4
floitsch
LGTM.
5 years, 11 months ago (2015-01-19 14:43:46 UTC) #6
karlklose
LGTM. https://codereview.chromium.org/813503005/diff/40001/tests/lib/mirrors/mirror_in_static_init_test.dart File tests/lib/mirrors/mirror_in_static_init_test.dart (right): https://codereview.chromium.org/813503005/diff/40001/tests/lib/mirrors/mirror_in_static_init_test.dart#newcode7 tests/lib/mirrors/mirror_in_static_init_test.dart:7: // This is a regression test of the ...
5 years, 11 months ago (2015-01-19 14:43:55 UTC) #8
sigurdm
https://codereview.chromium.org/813503005/diff/40001/tests/lib/mirrors/mirror_in_static_init_test.dart File tests/lib/mirrors/mirror_in_static_init_test.dart (right): https://codereview.chromium.org/813503005/diff/40001/tests/lib/mirrors/mirror_in_static_init_test.dart#newcode7 tests/lib/mirrors/mirror_in_static_init_test.dart:7: // This is a regression test of the VM. ...
5 years, 11 months ago (2015-01-19 14:48:37 UTC) #9
sigurdm
5 years, 11 months ago (2015-01-19 14:52:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as 42992 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698