Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 813163010: Make all tests pass ASAN. (Closed)

Created:
5 years, 11 months ago by koda
Modified:
5 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make all tests pass ASAN. Unpoison additional locations touched by profiler's stack walking. Use return value of Isolate::GetProfilerStackBounds. Commands to build and test: export CXX="third_party/clang/linux/bin/clang++ -fsanitize=address -fPIC" gclient runhooks ./tools/build.py -m debug -a x64 runtime ASAN_OPTIONS=handle_segv=0 python tools/test.py --report --time --mode=debug --arch=x64 --compiler=none --runtime=vm --failure-summary --write-debug-log --write-test-outcome-log --copy-coredumps --exclude-suite=pkg --checked R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42635

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M runtime/vm/profiler.cc View 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 11 months ago (2014-12-29 20:52:05 UTC) #1
Ivan Posva
LGTM -ip
5 years, 11 months ago (2015-01-06 00:47:59 UTC) #2
koda
5 years, 11 months ago (2015-01-06 15:44:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r42635 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698