Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 812733003: Revert "Tweaks in the VM's typed_data implementations." (Closed)

Created:
5 years, 11 months ago by Vyacheslav Egorov (Google)
Modified:
5 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Tweaks in the VM's typed_data implementations." This reverts commit r42951. Reason: checked mode breakage. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -213 lines) Patch
M runtime/lib/typed_data.dart View 76 chunks +111 lines, -111 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 9 chunks +47 lines, -47 lines 0 comments Download
M runtime/vm/method_recognizer.h View 3 chunks +50 lines, -50 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
5 years, 11 months ago (2015-01-16 12:14:38 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 42952 (presubmit successful).
5 years, 11 months ago (2015-01-16 12:14:59 UTC) #2
Florian Schneider
5 years, 11 months ago (2015-01-16 12:15:33 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698