Issue 812673009: - Move VM specific helpers to the common dart:io patch file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 812673009: - Move VM specific helpers to the common dart:io patch file. (Closed)

Created:
5 years, 11 months ago by Ivan Posva

Modified:
5 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Move VM specific helpers to the common dart:io patch file. Committed: https://code.google.com/p/dart/source/detail?r=42675

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	runtime/bin/common_patch.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	sdk/lib/io/timer_impl.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

TBR -Ivan P.S. It is not clear from the documentation how to add values to ...

5 years, 11 months ago (2015-01-07 23:01:51 UTC) #2

Ivan Posva

Committed patchset #1 (id:1) manually as r42675 (presubmit successful).

5 years, 11 months ago (2015-01-07 23:02:10 UTC) #3

Message was sent while issue was closed.

LGTM

I'll update the comment with an example.