Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 812593008: Completion support for loop labels. (Closed)

Created:
5 years, 11 months ago by Paul Berry
Modified:
5 years, 11 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Completion support for loop labels. Break and continue statements inside loops now have their targets properly completed. Continue statements inside switch statements will be addressed in a future CL. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=42781

Patch Set 1 #

Patch Set 2 : Fix problems with toplevel variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -58 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 2 chunks +116 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 1 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 3 chunks +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 21 chunks +62 lines, -52 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 1 chunk +139 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 11 months ago (2015-01-09 22:56:01 UTC) #2
danrubel
LGTM
5 years, 11 months ago (2015-01-12 02:22:01 UTC) #3
Paul Berry
5 years, 11 months ago (2015-01-12 17:37:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698