Change signature of lookupConstructor to only require a name.

Change signature of lookupConstructor to only require a name.

BUG=
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43067

Reverted: https://code.google.com/p/dart/source/detail?r=43068

Committed: https://code.google.com/p/dart/source/detail?r=43272

[herhut, 2015-01-07 12:20:28]

Patchset #2 (id:20001) has been deleted

[herhut, 2015-01-07 12:20:44]

PTAL

[herhut, 2015-01-07 13:19:26]

Patchset #3 (id:60001) has been deleted

[Johnni Winther, 2015-01-08 09:47:44]

lgtm

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/com...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/com...
pkg/compiler/lib/src/compiler.dart:1359: intEnvironment =
intClass.lookupConstructor(fromEnvironmentSelector.name);
Do we still need [fromEnvironmentSelector] as a [Selector] after this CL? If
not, replace it with a constant for the name.

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/backend.dart:856: return
implementation.validateConstructorLookupResults(selector,
Remove [Element.validateConstructorLookupResults] and
[BaseElement.validateConstructorLookupResults] and inline the check here.

Remember to update modely.dart in pkg/analyzer2dart when change elements.dart

[herhut, 2015-01-22 10:32:52]

Committed patchset #4 (id:100001) manually as 43067 (presubmit successful).

[herhut, 2015-01-22 10:33:20]

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/com...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/com...
pkg/compiler/lib/src/compiler.dart:1359: intEnvironment =
intClass.lookupConstructor(fromEnvironmentSelector.name);
On 2015/01/08 09:47:44, Johnni Winther wrote:
> Do we still need [fromEnvironmentSelector] as a [Selector] after this CL? If
> not, replace it with a constant for the name.

Done.

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/812523002/diff/80001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/backend.dart:856: return
implementation.validateConstructorLookupResults(selector,
On 2015/01/08 09:47:44, Johnni Winther wrote:
> Remove [Element.validateConstructorLookupResults] and
> [BaseElement.validateConstructorLookupResults] and inline the check here.
> 
> Remember to update modely.dart in pkg/analyzer2dart when change elements.dart

Done.

[herhut, 2015-01-22 11:52:05]

PTAL:

I had rebased in the meanwhile. The only real change is in line 2405 of
modelx.dart. I only check the function signature for default constructors if it
has been computed.

[Johnni Winther, 2015-01-26 08:38:56]

On 2015/01/22 11:52:05, herhut wrote:
> PTAL:
> 
> I had rebased in the meanwhile. The only real change is in line 2405 of
> modelx.dart. I only check the function signature for default constructors if
it
> has been computed.

That might hide an invariant breach. What problems did you encounter without the
check for hasFunctionSignature?

[herhut, 2015-01-26 09:30:47]

On 2015/01/26 08:38:56, Johnni Winther wrote:
> On 2015/01/22 11:52:05, herhut wrote:
> > PTAL:
> > 
> > I had rebased in the meanwhile. The only real change is in line 2405 of
> > modelx.dart. I only check the function signature for default constructors if
> it
> > has been computed.
> 
> That might hide an invariant breach. What problems did you encounter without
the
> check for hasFunctionSignature?

The helper Elements.isFixedListConstructorCall calls getDefaultConstructor to
get hold of the default constructor of List, even though it might not be
resolved. It does not actually need the constructor, it just uses it to compare
another element against it. An alternative would be to return `null` in such
cases, as no default constructor is available.

[herhut, 2015-01-29 09:29:51]

As discussed this now returns null.

[herhut, 2015-01-29 09:34:56]

Committed patchset #6 (id:140001) manually as 43272 (presubmit successful).