Fix analyzer2dart end2end.

Fix analyzer2dart end2end.

BUG=http://dartbug.com/21872
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42453

[Johnni Winther, 2014-12-18 09:34:26]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2014-12-18 09:49:34]

LGTM.

https://codereview.chromium.org/812333002/diff/1/pkg/analyzer2dart/lib/src/da...
File pkg/analyzer2dart/lib/src/dart_backend.dart (right):

https://codereview.chromium.org/812333002/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:108: spanFromSpannable(Spannable
node) {
Why this change?

https://codereview.chromium.org/812333002/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend.dart (right):

https://codereview.chromium.org/812333002/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend.dart:531: void traceCompilation(String
name) {}
Make these two functions abstract?

[Johnni Winther, 2014-12-18 10:05:38]

https://codereview.chromium.org/812333002/diff/1/pkg/analyzer2dart/lib/src/da...
File pkg/analyzer2dart/lib/src/dart_backend.dart (right):

https://codereview.chromium.org/812333002/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:108: spanFromSpannable(Spannable
node) {
On 2014/12/18 09:49:34, karlklose wrote:
> Why this change?

SourceSpan was not imported.

https://codereview.chromium.org/812333002/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend.dart (right):

https://codereview.chromium.org/812333002/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend.dart:531: void traceCompilation(String
name) {}
On 2014/12/18 09:49:34, karlklose wrote:
> Make these two functions abstract?

Done.

[Johnni Winther, 2014-12-18 10:20:18]

Committed patchset #3 (id:40001) manually as 42453 (presubmit successful).