Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812233004: Add CodeOutput to prepare for emission without in-memory buffers. (Closed)

Created:
5 years, 11 months ago by Johnni Winther
Modified:
5 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add CodeOutput to prepare for emission without in-memory buffers. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42573

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Reinsert return. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -458 lines) Patch
D pkg/compiler/lib/src/code_buffer.dart View 1 chunk +0 lines, -129 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 2 chunks +1 line, -1 line 0 comments Download
A pkg/compiler/lib/src/io/code_output.dart View 1 2 1 chunk +218 lines, -0 lines 0 comments Download
A + pkg/compiler/lib/src/io/source_map_builder.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js/printer.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_emitter.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 14 chunks +32 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/source_file.dart View 1 chunk +10 lines, -1 line 0 comments Download
D pkg/compiler/lib/src/source_map_builder.dart View 1 chunk +0 lines, -267 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 11 months ago (2014-12-29 14:27:14 UTC) #2
floitsch
LGTM! https://codereview.chromium.org/812233004/diff/1/pkg/compiler/lib/src/io/code_output.dart File pkg/compiler/lib/src/io/code_output.dart (right): https://codereview.chromium.org/812233004/diff/1/pkg/compiler/lib/src/io/code_output.dart#newcode21 pkg/compiler/lib/src/io/code_output.dart:21: void writeInternal(String text); private? https://codereview.chromium.org/812233004/diff/1/pkg/compiler/lib/src/io/code_output.dart#newcode27 pkg/compiler/lib/src/io/code_output.dart:27: return addBuffer(object); ...
5 years, 11 months ago (2014-12-29 18:36:35 UTC) #3
Johnni Winther
https://codereview.chromium.org/812233004/diff/1/pkg/compiler/lib/src/io/code_output.dart File pkg/compiler/lib/src/io/code_output.dart (right): https://codereview.chromium.org/812233004/diff/1/pkg/compiler/lib/src/io/code_output.dart#newcode21 pkg/compiler/lib/src/io/code_output.dart:21: void writeInternal(String text); On 2014/12/29 18:36:35, floitsch wrote: > ...
5 years, 11 months ago (2014-12-30 11:05:18 UTC) #4
Johnni Winther
5 years, 11 months ago (2014-12-30 11:41:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 42573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698