Issue 811823002: Support remaping of pair location inside materializations for slow paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811823002: Support remaping of pair location inside materializations for slow paths. (Closed)

Created:
6 years ago by Vyacheslav Egorov (Google)

Modified:
6 years ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Support remaping of pair location inside materializations for slow paths. Move remaping logic into Location::RemapForSlowPath to ensure that it is shared and will not get out of sync again. BUG=http://dartbug.com/21887 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=42396

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -84 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+4 lines, -50 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+4 lines, -30 lines	0 comments	Download
M	runtime/vm/locations.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	tests/standalone/pair_location_remaping_test.dart	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

LGTM. https://codereview.chromium.org/811823002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/811823002/diff/1/tests/standalone/standalone.status#newcode91 tests/standalone/standalone.status:91: pair_location_remaping_test: Skip s/remaping/remapping/g

6 years ago (2014-12-16 15:09:24 UTC) #3

Vyacheslav Egorov (Google)

6 years ago (2014-12-16 15:19:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42396 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages