Modify Bigint _mulAdd, _sqrAdd, _estQuotientDigit, and Montgomery _mulMod

Modify Bigint _mulAdd, _sqrAdd, _estQuotientDigit, and Montgomery _mulMod
methods to return the number of digits processed, so that their intrinsified
versions on 64-bit platforms can process digit pairs.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42568

[regis, 2014-12-23 23:58:45]

regis@google.com changed reviewers:
+ zra@google.com

[regis, 2014-12-23 23:58:45]

No hurry.
Merry Christmas!

[zra, 2014-12-29 18:00:11]

lgtm

Just to be clear, none of the intrinsics should return 2, yet. This is a
preparatory CL for that change, correct? 

+srdjan for thoughts on factory recognizer.

https://codereview.chromium.org/811763004/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (left):

https://codereview.chromium.org/811763004/diff/20001/runtime/vm/object.cc#old...
runtime/vm/object.cc:6758: // sed -i .bak -f /tmp/newkeys
runtime/vm/flow_graph_builder.h
Unrelated to this change, but I wonder if RECOGNIZED_LIST_FACTORY_LIST and class
FactoryRecognizer in flow_graph_builder.h should be pulled out into a new file
factory_recognizer.h/cc.

[srdjan, 2014-12-29 18:24:46]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2014-12-29 18:24:47]

https://codereview.chromium.org/811763004/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (left):

https://codereview.chromium.org/811763004/diff/20001/runtime/vm/object.cc#old...
runtime/vm/object.cc:6758: // sed -i .bak -f /tmp/newkeys
runtime/vm/flow_graph_builder.h
On 2014/12/29 18:00:11, zra wrote:
> Unrelated to this change, but I wonder if RECOGNIZED_LIST_FACTORY_LIST and
class
> FactoryRecognizer in flow_graph_builder.h should be pulled out into a new file
> factory_recognizer.h/cc.

Maybe move it into method_recognizer.{h,cc}, but I do not feel strongly about
moving it now.

[regis, 2014-12-29 18:40:16]

On 2014/12/29 18:00:11, zra wrote:
> lgtm
> 
> Just to be clear, none of the intrinsics should return 2, yet. This is a
> preparatory CL for that change, correct? 
> 
Yes, exactly. Expect more reviews :-)

Thanks!


> +srdjan for thoughts on factory recognizer.
> 
> https://codereview.chromium.org/811763004/diff/20001/runtime/vm/object.cc
> File runtime/vm/object.cc (left):
> 
>
https://codereview.chromium.org/811763004/diff/20001/runtime/vm/object.cc#old...
> runtime/vm/object.cc:6758: // sed -i .bak -f /tmp/newkeys
> runtime/vm/flow_graph_builder.h
> Unrelated to this change, but I wonder if RECOGNIZED_LIST_FACTORY_LIST and
class
> FactoryRecognizer in flow_graph_builder.h should be pulled out into a new file
> factory_recognizer.h/cc.

[regis, 2014-12-29 18:40:51]

Committed patchset #2 (id:20001) manually as r42568 (presubmit successful).