Recover from incorrectly ordered library tags.

Recover from incorrectly ordered library tags.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42455

[ahe, 2014-12-16 14:45:50]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2014-12-16 14:45:51]

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
File dart/pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2181: static const MessageKind
LIBRARY_TAG_MUST_BE_FIRST = const MessageKind(
Luke: Any comments regarding these error messages?

[lukechurch, 2014-12-16 15:18:15]

lukechurch@google.com changed reviewers:
+ lukechurch@google.com

[lukechurch, 2014-12-16 15:18:16]

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
File dart/pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2182: "Library declaration should come
before other declartions.",
The library dec.....

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2195: examples: const [
s/'all but the first library '/'all other library declarations'?

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2204: "Import declarations must come
before parts.",
Is there a reason for the inconsistency between should [earlier] and must here?

[ahe, 2014-12-16 15:27:18]

Thank you, Luke, I've incorporated your suggestions.

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
File dart/pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2182: "Library declaration should come
before other declartions.",
On 2014/12/16 15:18:16, lukechurch wrote:
> The library dec.....

Done.

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2195: examples: const [
On 2014/12/16 15:18:16, lukechurch wrote:
> s/'all but the first library '/'all other library declarations'?

Done.

https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
dart/pkg/compiler/lib/src/warnings.dart:2204: "Import declarations must come
before parts.",
On 2014/12/16 15:18:16, lukechurch wrote:
> Is there a reason for the inconsistency between should [earlier] and must
here?

I used "should" because I felt that sounded less harsh. Forgot it here. In most
standards, there is a semantic difference between "should" and "must", but I
don't think that matters in this context. Do you agree that "should" is less
harsh?

[lukechurch, 2014-12-16 15:32:06]

On 2014/12/16 15:27:18, ahe wrote:
> Thank you, Luke, I've incorporated your suggestions.
> 
>
https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
> File dart/pkg/compiler/lib/src/warnings.dart (right):
> 
>
https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
> dart/pkg/compiler/lib/src/warnings.dart:2182: "Library declaration should come
> before other declartions.",
> On 2014/12/16 15:18:16, lukechurch wrote:
> > The library dec.....
> 
> Done.
> 
>
https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
> dart/pkg/compiler/lib/src/warnings.dart:2195: examples: const [
> On 2014/12/16 15:18:16, lukechurch wrote:
> > s/'all but the first library '/'all other library declarations'?
> 
> Done.
> 
>
https://codereview.chromium.org/811583004/diff/1/dart/pkg/compiler/lib/src/wa...
> dart/pkg/compiler/lib/src/warnings.dart:2204: "Import declarations must come
> before parts.",
> On 2014/12/16 15:18:16, lukechurch wrote:
> > Is there a reason for the inconsistency between should [earlier] and must
> here?
> 
> I used "should" because I felt that sounded less harsh. Forgot it here. In
most
> standards, there is a semantic difference between "should" and "must", but I
> don't think that matters in this context. Do you agree that "should" is less
> harsh?

Yes, and in this case being harsh seems unhelpful, so lets go for should.

That is what I was checking, whether you were intending to express a semantic
difference or not, as not, lets go for should.

[ahe, 2014-12-17 09:47:44]

PTAL, realized that I could use states instead of a bool to tell if a library
declaration has been seen.

[ahe, 2014-12-17 09:50:16]

Patchset #4 (id:60001) has been deleted

[ahe, 2014-12-17 09:57:06]

A bool is needed after all. Added a test which illustrates that.

[ahe, 2014-12-18 09:43:04]

ping :-)

[Johnni Winther, 2014-12-18 10:05:11]

lgtm

https://codereview.chromium.org/811583004/diff/80001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/811583004/diff/80001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/warnings.dart:2182: "The library declaration should
come before other declartions.",
'declartions' -> 'declarations'.

[ahe, 2014-12-18 11:05:13]

Thank you, Johnni!

https://codereview.chromium.org/811583004/diff/80001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/811583004/diff/80001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/warnings.dart:2182: "The library declaration should
come before other declartions.",
On 2014/12/18 10:05:11, Johnni Winther wrote:
> 'declartions' -> 'declarations'.

Done.

[ahe, 2014-12-18 11:32:31]

Committed patchset #5 (id:100001) manually as 42455 (presubmit successful).