Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 811453002: Fix release x64 build: (Closed)

Created:
6 years ago by Vyacheslav Egorov (Google)
Modified:
6 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix release x64 build: - don't try using near jumps anymore; - initialize variables in vm/cc/Bitwise with zeros. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M runtime/vm/assembler_x64_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
6 years ago (2014-12-15 20:00:52 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 42373 (presubmit successful).
6 years ago (2014-12-15 20:01:21 UTC) #2
Florian Schneider
6 years ago (2014-12-16 09:09:43 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698