Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 810783002: Clean up FunctionDefinition in the IR S-expression representation. (Closed)

Created:
6 years ago by Kevin Millikin (Google)
Modified:
6 years ago
Reviewers:
asgerf, karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Clean up FunctionDefinition in the IR S-expression representation. Separate value parameters from the continuation for symmetry with function invocations. Do not make closure variables optional. Do not use '{' or '}', since it makes parsing more difficult and probably screws up other tools that work with S-expressions. Move closure variables after the parameters and just before the body, since they are not part of the signature, do not appear at call sites, and the implicit box creation happens at the beginning of the body anyway. R=asgerf@google.com, karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -168 lines) Patch
M pkg/analyzer2dart/test/sexpr_data.dart View 83 chunks +89 lines, -89 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 4 chunks +16 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 17 chunks +20 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 8 chunks +13 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 13 chunks +23 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 2 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
6 years ago (2014-12-16 14:11:22 UTC) #1
asgerf
LGTM ... except I'll have to counter-update the test cases when closure variables are overhauled ...
6 years ago (2014-12-16 14:17:32 UTC) #2
Kevin Millikin (Google)
6 years ago (2014-12-16 14:30:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698