Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 810333007: Add a done getter to Client, Server, and Peer. (Closed)

Created:
5 years, 11 months ago by nweiz
Modified:
5 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/json_rpc_2@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/client.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/peer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/server.dart View 2 chunks +8 lines, -1 line 0 comments Download
M lib/src/two_way_stream.dart View 3 chunks +12 lines, -12 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 11 months ago (2015-01-16 02:30:27 UTC) #1
Bob Nystrom
lgtm
5 years, 11 months ago (2015-01-16 17:07:21 UTC) #2
nweiz
5 years, 11 months ago (2015-01-21 02:20:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c840446eaff7addf4de3843ac4a5769bcff5f67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698