Issue 810243002: Support synthetic default constructors.

Issue 810243002: Support synthetic default constructors. (Closed)

Created:
6 years ago by karlklose

Modified:
6 years ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Support synthetic default constructors. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42452

Patch Set 2 : Bailout instead of calling internalError. #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -7 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart	View	1	3 chunks	+25 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_basic.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sigurdm

lgtm https://codereview.chromium.org/810243002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart (right): https://codereview.chromium.org/810243002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart#newcode299 pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart:299: if (!constructor.isDefaultConstructor) { Maybe a bailout is better

6 years ago (2014-12-18 09:37:37 UTC) #2

karlklose

https://codereview.chromium.org/810243002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart (right): https://codereview.chromium.org/810243002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart#newcode299 pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart:299: if (!constructor.isDefaultConstructor) { On 2014/12/18 09:37:37, sigurdm wrote: > ...

6 years ago (2014-12-18 09:44:09 UTC) #3

karlklose

6 years ago (2014-12-18 09:53:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42452 (presubmit successful).

Expand Messages | Collapse Messages