Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 810233006: Mark failing csp tests as failing in browser only. (Closed)

Created:
5 years, 11 months ago by sigurdm
Modified:
5 years, 11 months ago
Reviewers:
floitsch, zarah
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Mark failing csp tests as failing in browser only. BUG= R=floitsch@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42628

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix redundancy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sigurdm
5 years, 11 months ago (2015-01-06 12:17:37 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/810233006/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/810233006/diff/1/tests/language/language_dart2js.status#newcode5 tests/language/language_dart2js.status:5: [ $compiler == dart2js && $csp && $runtime ...
5 years, 11 months ago (2015-01-06 12:20:28 UTC) #4
sigurdm
https://codereview.chromium.org/810233006/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/810233006/diff/1/tests/language/language_dart2js.status#newcode5 tests/language/language_dart2js.status:5: [ $compiler == dart2js && $csp && $runtime == ...
5 years, 11 months ago (2015-01-06 12:27:28 UTC) #5
zarah
lgtm
5 years, 11 months ago (2015-01-06 12:27:59 UTC) #6
sigurdm
5 years, 11 months ago (2015-01-06 12:32:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698