Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 810223002: Remove the http package from the repo. (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
CC:
reviews_dartlang.org, ricow1, Siggi Cherem (dart-lang), ahe
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove the http package from the repo. This also does away with the pub_packages build target. R=ahe@google.com, rnystrom@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=42469

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3891 lines) Patch
D pkg/http/CHANGELOG.md View 1 chunk +0 lines, -40 lines 0 comments Download
D pkg/http/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/http/README.md View 1 chunk +0 lines, -100 lines 0 comments Download
D pkg/http/lib/browser_client.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D pkg/http/lib/http.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D pkg/http/lib/src/base_client.dart View 1 chunk +0 lines, -169 lines 0 comments Download
D pkg/http/lib/src/base_request.dart View 1 chunk +0 lines, -140 lines 0 comments Download
D pkg/http/lib/src/base_response.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D pkg/http/lib/src/byte_stream.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D pkg/http/lib/src/client.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D pkg/http/lib/src/exception.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D pkg/http/lib/src/io.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D pkg/http/lib/src/io_client.dart View 1 chunk +0 lines, -88 lines 0 comments Download
D pkg/http/lib/src/mock_client.dart View 1 chunk +0 lines, -89 lines 0 comments Download
D pkg/http/lib/src/multipart_file.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D pkg/http/lib/src/multipart_request.dart View 1 chunk +0 lines, -176 lines 0 comments Download
D pkg/http/lib/src/request.dart View 1 chunk +0 lines, -163 lines 0 comments Download
D pkg/http/lib/src/response.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D pkg/http/lib/src/streamed_request.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D pkg/http/lib/src/streamed_response.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D pkg/http/lib/src/utils.dart View 1 chunk +0 lines, -201 lines 0 comments Download
D pkg/http/lib/testing.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/http/pubspec.yaml View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/http/test/html/client_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/http/test/html/streamed_request_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/http/test/html/utils.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/http/test/io/client_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D pkg/http/test/io/http_test.dart View 1 chunk +0 lines, -334 lines 0 comments Download
D pkg/http/test/io/multipart_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D pkg/http/test/io/request_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D pkg/http/test/io/streamed_request_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D pkg/http/test/io/utils.dart View 1 chunk +0 lines, -151 lines 0 comments Download
D pkg/http/test/mock_client_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D pkg/http/test/multipart_test.dart View 1 chunk +0 lines, -235 lines 0 comments Download
D pkg/http/test/request_test.dart View 1 chunk +0 lines, -356 lines 0 comments Download
D pkg/http/test/response_test.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D pkg/http/test/streamed_request_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/http/test/utils.dart View 1 chunk +0 lines, -118 lines 0 comments Download
M pkg/pkg.gyp View 1 chunk +0 lines, -48 lines 2 comments Download
M pkg/pkg_files.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
M sdk/bin/pub View 1 chunk +1 line, -1 line 0 comments Download
D tools/remove_html_imports.py View 1 chunk +0 lines, -39 lines 0 comments Download
M utils/pub/pub.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nweiz
6 years ago (2014-12-18 02:21:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/810223002/diff/1/pkg/pkg.gyp File pkg/pkg.gyp (left): https://codereview.chromium.org/810223002/diff/1/pkg/pkg.gyp#oldcode49 pkg/pkg.gyp:49: '../tools/remove_html_imports.py', was this just not needed anymore, or ...
6 years ago (2014-12-18 17:02:44 UTC) #4
Bob Nystrom
LGTM! It's nice to clean out the old platform-specific code stuff too.
6 years ago (2014-12-18 18:49:38 UTC) #5
nweiz
https://codereview.chromium.org/810223002/diff/1/pkg/pkg.gyp File pkg/pkg.gyp (left): https://codereview.chromium.org/810223002/diff/1/pkg/pkg.gyp#oldcode49 pkg/pkg.gyp:49: '../tools/remove_html_imports.py', On 2014/12/18 17:02:44, Siggi Cherem (dart-lang) wrote: > ...
6 years ago (2014-12-18 18:51:51 UTC) #6
ahe
lgtm
6 years ago (2014-12-18 18:56:39 UTC) #8
nweiz
6 years ago (2014-12-18 19:04:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698