Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 810183003: Split js_backend_cps_ir tests into multiple test units. (Closed)

Created:
5 years, 11 months ago by asgerf
Modified:
5 years, 11 months ago
Reviewers:
karlklose, sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Split js_backend_cps_ir tests into multiple test units. When testing everything from a single entry point, the time budget does not increase as we add more test cases. So that approach did not scale. BUG= Committed: https://code.google.com/p/dart/source/detail?r=42804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -573 lines) Patch
A + tests/compiler/dart2js/js_backend_cps_ir.dart View 3 chunks +2 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_basic.dart View 1 chunk +0 lines, -103 lines 0 comments Download
A + tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 2 chunks +7 lines, -1 line 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_closures.dart View 1 chunk +0 lines, -125 lines 0 comments Download
A + tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart View 2 chunks +7 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_control_flow.dart View 1 chunk +0 lines, -140 lines 0 comments Download
A + tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_interceptors.dart View 1 chunk +0 lines, -27 lines 0 comments Download
A + tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart View 2 chunks +7 lines, -1 line 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_literals.dart View 1 chunk +0 lines, -34 lines 0 comments Download
A + tests/compiler/dart2js/js_backend_cps_ir_literals_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_operators.dart View 1 chunk +0 lines, -45 lines 0 comments Download
A + tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
D tests/compiler/dart2js/js_backend_cps_ir_test.dart View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
Committed patchset #1 (id:1) manually as 42804 (presubmit successful).
5 years, 11 months ago (2015-01-13 12:50:48 UTC) #1
asgerf
TBR
5 years, 11 months ago (2015-01-13 12:51:26 UTC) #3
karlklose
5 years, 11 months ago (2015-01-13 12:54:30 UTC) #4 
LGTM,

but I prefer not to TBR non-trivial changes like this.

Powered by Google App Engine
This is Rietveld 408576698