Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 810133002: Fix shelf_web_socket's Connection handling. (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix shelf_web_socket's Connection handling. R=rnystrom@google.com BUG=21894 Committed: https://code.google.com/p/dart/source/detail?r=42446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A pkg/shelf_web_socket/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/shelf_web_socket/lib/src/web_socket_handler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/shelf_web_socket/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/shelf_web_socket/test/web_socket_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years ago (2014-12-17 20:20:13 UTC) #1
Bob Nystrom
lgtm
6 years ago (2014-12-18 00:33:57 UTC) #2
nweiz
6 years ago (2014-12-18 00:58:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698