Issue 80993003: Remove type annotation from _TypedListBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 80993003: Remove type annotation from _TypedListBase (Closed)

Created:
7 years, 1 month ago by Cutch

Modified:
7 years ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove type annotation from _TypedListBase BUG=https://code.google.com/p/dart/issues/detail?id=12861 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=30685

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -43 lines)			Patch
M	runtime/bin/vmservice/client/.gitignore	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View		8 chunks	+21 lines, -21 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+0 lines, -21 lines	0 comments	Download

Total messages: 3 (0 generated)

hausner

LGTM. Could look even better if annotation with 'dynamic' was removed entirely. It is just ...

7 years ago (2013-11-24 08:05:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r30685 (presubmit successful).