Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 809793002: Improve nomenclature of new AnalysisContext async method. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, Brian Wilkerson
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Improve nomenclature of new AnalysisContext async method. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=42404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +35 lines, -35 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years ago (2014-12-16 17:46:13 UTC) #2
danrubel
lgtm
6 years ago (2014-12-16 17:54:38 UTC) #3
Paul Berry
6 years ago (2014-12-16 18:05:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698