Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 809603005: Do less inlining in lazy initializer expressions. (Closed)

Created:
6 years ago by sra1
Modified:
6 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, herhut
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Do less inlining in lazy initializer expressions. Lazy initializer expressions are executed at most once, so should be optimized for size rather than speed. This currently means only inlining when the call is the only use of the function, sunce we don't really have the right information to do a good job in other cases. Also use this heuristic to inline in throw expressions - this eliminates the constructor function for several exception classes that have a single throw site. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42420

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 5 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
This helps by about 1% on an app that uses protocol buffers as the descriptors ...
6 years ago (2014-12-16 23:40:49 UTC) #2
floitsch
LGTM!
6 years ago (2014-12-17 00:17:28 UTC) #3
sra1
6 years ago (2014-12-17 01:49:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698