Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809313006: Implement incremental tests with multiple files. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Implement incremental tests with multiple files. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42459

Patch Set 1 #

Total comments: 2

Patch Set 2 : Long line. #

Patch Set 3 : Merged with r42458. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -39 lines) Patch
M dart/tests/try/poi/compiler_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 2 chunks +43 lines, -11 lines 0 comments Download
M dart/tests/try/web/program_result.dart View 1 3 chunks +101 lines, -16 lines 0 comments Download
M dart/tests/try/web/web_compiler_test_case.dart View 4 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahe
6 years ago (2014-12-18 13:41:49 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/809313006/diff/1/dart/tests/try/web/program_result.dart File dart/tests/try/web/program_result.dart (right): https://codereview.chromium.org/809313006/diff/1/dart/tests/try/web/program_result.dart#newcode65 dart/tests/try/web/program_result.dart:65: "(${sources.length} sources, ${expectations.length} expectations)."); Long line.
6 years ago (2014-12-18 14:01:36 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/809313006/diff/1/dart/tests/try/web/program_result.dart File dart/tests/try/web/program_result.dart (right): https://codereview.chromium.org/809313006/diff/1/dart/tests/try/web/program_result.dart#newcode65 dart/tests/try/web/program_result.dart:65: "(${sources.length} sources, ${expectations.length} expectations)."); On 2014/12/18 ...
6 years ago (2014-12-18 14:59:10 UTC) #4
ahe
6 years ago (2014-12-18 15:01:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 42459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698