Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 80923003: Fix small bug in RecursiveVisitor (Closed)

Created:
7 years, 1 month ago by justinfagnani
Modified:
7 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix small bug in RecursiveVisitor BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30547

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M pkg/polymer_expressions/lib/visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer_expressions/test/all_tests.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/polymer_expressions/test/visitor_test.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
justinfagnani
7 years, 1 month ago (2013-11-21 21:43:32 UTC) #1
Jennifer Messerly
lgtm. is it covered by a test? if not, add one?
7 years, 1 month ago (2013-11-21 21:47:59 UTC) #2
justinfagnani
7 years, 1 month ago (2013-11-21 22:01:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698