Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809213003: Add format API (Closed)

Created:
5 years, 11 months ago by Brian Wilkerson
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Additional changes #

Patch Set 3 : Add handler hook and missed classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -20 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +14 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FormatConsumer.java View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 1 4 chunks +15 lines, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FormatProcessor.java View 1 2 3 chunks +16 lines, -16 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java View 1 3 chunks +26 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 1 chunk +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 1 3 chunks +118 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +60 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 2 2 chunks +20 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +193 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Brian Wilkerson
This adds basic support both on the server and Java client sides for passing a ...
5 years, 11 months ago (2015-01-06 20:02:24 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-06 20:15:15 UTC) #3
pquitslund
LGTM!
5 years, 11 months ago (2015-01-06 21:26:01 UTC) #4
Bob Nystrom
LGTM!
5 years, 11 months ago (2015-01-06 21:41:42 UTC) #5
Brian Wilkerson
Committed patchset #3 (id:40001) manually as 42648 (presubmit successful).
5 years, 11 months ago (2015-01-06 22:45:51 UTC) #6
jwren
5 years, 11 months ago (2015-01-07 00:45:19 UTC) #7
Message was sent while issue was closed. 
On 2015/01/06 22:45:51, Brian Wilkerson wrote:
> Committed patchset #3 (id:40001) manually as 42648 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698