Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 808953004: Recover from fatal parser errors. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/parser_error_only
Visibility:
Public.

Description

Recover from fatal parser errors. BUG=https://code.google.com/p/dart/issues/detail?id=22022 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42861

Patch Set 1 : #

Patch Set 2 : Fix a typo, and work around unused API test. #

Patch Set 3 : Merged with r42860. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -44 lines) Patch
M dart/pkg/compiler/lib/src/patch_parser.dart View 2 chunks +17 lines, -3 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +7 lines, -4 lines 0 comments Download
M dart/pkg/compiler/lib/src/scanner/class_element_parser.dart View 1 chunk +24 lines, -5 lines 0 comments Download
M dart/pkg/compiler/lib/src/scanner/listener.dart View 4 chunks +10 lines, -30 lines 0 comments Download
M dart/pkg/compiler/lib/src/scanner/parser_task.dart View 1 chunk +6 lines, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/scanner/scanner_task.dart View 1 chunk +5 lines, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/use_unused_api.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
I have already created a CL which removes CompilerCancelledException. I'll send that out shortly.
5 years, 11 months ago (2015-01-13 11:22:39 UTC) #4
ahe
Uploaded new patch set. Ready for review.
5 years, 11 months ago (2015-01-13 12:10:20 UTC) #5
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-13 13:09:18 UTC) #6
ahe
5 years, 11 months ago (2015-01-14 12:48:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as 42861 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698