Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 808643004: Support breakpoints in deferred libraries (Closed)

Created:
6 years ago by hausner
Modified:
6 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, keertip
Visibility:
Public.

Description

Support breakpoints in deferred libraries This CL introduces latent breakpoints, which are bp in urls that are not yet loaded. When the VM loads additional scripts through deferred libraries, latent breakpoints get set. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42510

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -28 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 1 2 7 chunks +19 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 14 chunks +170 lines, -20 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
A tests/standalone/debugger/deferred_code_lib.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
A tests/standalone/debugger/deferred_code_test.dart View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
6 years ago (2014-12-17 21:34:08 UTC) #2
Ivan Posva
LGTM with e -Ivan https://codereview.chromium.org/808643004/diff/20001/runtime/vm/debugger.h File runtime/vm/debugger.h (right): https://codereview.chromium.org/808643004/diff/20001/runtime/vm/debugger.h#newcode43 runtime/vm/debugger.h:43: // Create a new latent ...
6 years ago (2014-12-18 23:18:40 UTC) #3
hausner
Thank you. https://codereview.chromium.org/808643004/diff/20001/runtime/vm/debugger.h File runtime/vm/debugger.h (right): https://codereview.chromium.org/808643004/diff/20001/runtime/vm/debugger.h#newcode43 runtime/vm/debugger.h:43: // Create a new latent brakpoint. On ...
6 years ago (2014-12-18 23:26:49 UTC) #4
hausner
6 years ago (2014-12-19 16:36:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r42510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698