Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1873)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 807283002: Add examples to illustrate the functionality of CancelableCompleter. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add examples to illustrate the functionality of CancelableCompleter. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=42414

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M pkg/analyzer/lib/src/cancelable_future.dart View 1 chunk +44 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years ago (2014-12-16 22:05:11 UTC) #2
Brian Wilkerson
LGTM. Thanks! https://codereview.chromium.org/807283002/diff/1/pkg/analyzer/lib/src/cancelable_future.dart File pkg/analyzer/lib/src/cancelable_future.dart (right): https://codereview.chromium.org/807283002/diff/1/pkg/analyzer/lib/src/cancelable_future.dart#newcode33 pkg/analyzer/lib/src/cancelable_future.dart:33: * print('Completed with error $error'); // (3) ...
6 years ago (2014-12-16 22:28:45 UTC) #3
Paul Berry
https://codereview.chromium.org/807283002/diff/1/pkg/analyzer/lib/src/cancelable_future.dart File pkg/analyzer/lib/src/cancelable_future.dart (right): https://codereview.chromium.org/807283002/diff/1/pkg/analyzer/lib/src/cancelable_future.dart#newcode33 pkg/analyzer/lib/src/cancelable_future.dart:33: * print('Completed with error $error'); // (3) On 2014/12/16 ...
6 years ago (2014-12-16 22:33:13 UTC) #4
Paul Berry
6 years ago (2014-12-16 22:35:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 42414 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698