Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 806973002: Cleanup access to Instruction's fields (especially deopt_id_). (Closed)

Created:
6 years ago by srdjan
Modified:
6 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Cleanup access to Instruction's fields (especially deopt_id_). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42405

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 1 4 chunks +19 lines, -15 lines 2 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
6 years ago (2014-12-15 23:22:46 UTC) #2
Cutch
lgtm with one suggestion https://codereview.chromium.org/806973002/diff/60001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/806973002/diff/60001/runtime/vm/intermediate_language.h#newcode2247 runtime/vm/intermediate_language.h:2247: void SetDeoptId(const Instruction& instr) { ...
6 years ago (2014-12-16 16:49:30 UTC) #3
srdjan
https://codereview.chromium.org/806973002/diff/60001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/806973002/diff/60001/runtime/vm/intermediate_language.h#newcode2247 runtime/vm/intermediate_language.h:2247: void SetDeoptId(const Instruction& instr) { On 2014/12/16 16:49:30, Cutch ...
6 years ago (2014-12-16 16:54:06 UTC) #4
srdjan
6 years ago (2014-12-16 18:27:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as r42405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698