Issue 806933002: Issue 21883. Add checks if type parameters can be used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 806933002: Issue 21883. Add checks if type parameters can be used. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Issue 21883. Add checks if type parameters can be used. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=21883 Committed: https://code.google.com/p/dart/source/detail?r=42377

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+280 lines, -19 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	3 chunks	+16 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	4 chunks	+25 lines, -6 lines	1 comment	Download
M	pkg/analysis_server/test/services/correction/assist_test.dart	View	3 chunks	+63 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	4 chunks	+172 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/806933002/diff/1/pkg/analysis_server/lib/src/services/correction/util.dart File pkg/analysis_server/lib/src/services/correction/util.dart (right): https://codereview.chromium.org/806933002/diff/1/pkg/analysis_server/lib/src/services/correction/util.dart#newcode1002 pkg/analysis_server/lib/src/services/correction/util.dart:1002: // TODO(scheglov) What's left to do?

6 years ago (2014-12-15 23:29:15 UTC) #2

scheglov

6 years ago (2014-12-16 00:29:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42377 (presubmit successful).

Expand Messages | Collapse Messages