Make futures returned by AnalysisContext cancelable.

Make futures returned by AnalysisContext cancelable.

R=brianwilkerson@google.com, danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42400

[Paul Berry, 2014-12-15 17:51:06]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com

[Brian Wilkerson, 2014-12-15 19:49:26]

LGTM

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/lib/src/cancela...
File pkg/analyzer/lib/src/cancelable_future.dart (right):

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/lib/src/cancela...
pkg/analyzer/lib/src/cancelable_future.dart:15: class CancelableCompleter<T>
implements Completer<T> {
I'd like to see doc comments for all of the classes and any public methods, and
wouldn't mind having some for the remaining fields and private methods. I think
more documentation would be good here because this code seems subtle (though
that might just be me).

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/lib/src/cancela...
pkg/analyzer/lib/src/cancelable_future.dart:42: * invoked if the future is
completed before being canceled.
And the future will be completed with an error before the callback is invoked.

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/engine_test.dart (right):

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/engine_test.dart:1162: while
(_context.performAnalysisTask().hasMoreWork) {}
We have normally put in some limit on the number of times we will invoke
performAnalysisTask before failing in order to guard against infinite loops.

[danrubel, 2014-12-15 20:32:33]

LGTM

[scheglov, 2014-12-15 21:31:19]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-12-15 21:31:19]

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/test_all.dart
File pkg/analyzer/test/test_all.dart (right):

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/test_all.d...
pkg/analyzer/test/test_all.dart:24: cancelable_future_test.main();
This will make this test suite 2 seconds slower :-(

[Paul Berry, 2014-12-16 16:58:06]

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/lib/src/cancela...
File pkg/analyzer/lib/src/cancelable_future.dart (right):

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/lib/src/cancela...
pkg/analyzer/lib/src/cancelable_future.dart:15: class CancelableCompleter<T>
implements Completer<T> {
On 2014/12/15 19:49:26, Brian Wilkerson wrote:
> I'd like to see doc comments for all of the classes and any public methods,
and
> wouldn't mind having some for the remaining fields and private methods. I
think
> more documentation would be good here because this code seems subtle (though
> that might just be me).

Done.

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/engine_test.dart (right):

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/engine_test.dart:1162: while
(_context.performAnalysisTask().hasMoreWork) {}
On 2014/12/15 19:49:26, Brian Wilkerson wrote:
> We have normally put in some limit on the number of times we will invoke
> performAnalysisTask before failing in order to guard against infinite loops.

Done.

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/test_all.dart
File pkg/analyzer/test/test_all.dart (right):

https://codereview.chromium.org/806733003/diff/1/pkg/analyzer/test/test_all.d...
pkg/analyzer/test/test_all.dart:24: cancelable_future_test.main();
On 2014/12/15 21:31:19, scheglov wrote:
> This will make this test suite 2 seconds slower :-(

I am open to suggestions for improving the test suite.

[Paul Berry, 2014-12-16 17:01:30]

Committed patchset #1 (id:1) manually as 42400 (presubmit successful).