Better handling of IPv6 with HTTP proxy

Better handling of IPv6 with HTTP proxy

Handle IPv6 numeric hosts in the proxy configuration.

Update the environment variable based proxy server cofiguration
to also handle that the host is an IPv6 numeric address enclosed in
[]'s. Also support IPv6 numeric addresses in []'s in the no_proxy
environment variable.

Also fixed the issue where an empty string value for the
environment variables http_proxy and friends caused the proxy
configuration to become ':1080'.

R=ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=30512

[Anders Johnsen, 2013-11-21 11:32:20]

lgtm

https://codereview.chromium.org/80673002/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/80673002/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1829: url.host == name.substring(1, name.length - 1))
||
"[${url.host}]" == name

?

[Søren Gjesse, 2013-11-21 12:05:27]

https://codereview.chromium.org/80673002/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/80673002/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1829: url.host == name.substring(1, name.length - 1))
||
On 2013/11/21 11:32:20, Anders Johnsen wrote:
> "[${url.host}]" == name
> 
> ?

Done.

[Søren Gjesse, 2013-11-21 12:05:31]

Committed patchset #2 manually as r30512 (presubmit successful).