Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 806153002: Mark two triaged co19-tests with issue number (Closed)

Created:
6 years ago by sigurdm
Modified:
6 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Mark two triaged co19-tests with issue number R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42381

Patch Set 1 #

Total comments: 2

Patch Set 2 : Turn issue references into urls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/co19/co19-dart2js.status View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
6 years ago (2014-12-16 07:48:35 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/806153002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/806153002/diff/1/tests/co19/co19-dart2js.status#newcode452 tests/co19/co19-dart2js.status:452: LibTest/convert/JsonCodec/encode_A01_t01: RuntimeError # co19 issue 735 Maybe add ...
6 years ago (2014-12-16 07:55:33 UTC) #4
sigurdm
https://codereview.chromium.org/806153002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/806153002/diff/1/tests/co19/co19-dart2js.status#newcode452 tests/co19/co19-dart2js.status:452: LibTest/convert/JsonCodec/encode_A01_t01: RuntimeError # co19 issue 735 On 2014/12/16 07:55:33, ...
6 years ago (2014-12-16 08:02:19 UTC) #5
sigurdm
6 years ago (2014-12-16 08:11:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698