cps-ir: Add support for intercepted calls.

cps-ir: Add support for intercepted calls.

Add an Interceptor IR node that encapsulates the receiver of a method call that (possibly) must be intercepted and replace the receiver of the call by the new node.

Currently we do no optimizations of the interceptor's intercepted class field based on type inference.

R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42385

Committed: https://code.google.com/p/dart/source/detail?r=42391

[karlklose, 2014-12-16 10:04:30]

Patchset #2 (id:20001) has been deleted

[sigurdm, 2014-12-16 11:44:56]

I just saw you moved the creation of the extra argument. I left the comment -
just ignore it.

lgtm except for the missing test

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right):

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:53: (Reference<Primitive>
r) => r.definition).toList()));
It would be nicer if you could just pass the arguments here. Maybe we should
change the contructor, or add another constructor to InvokeMethod.

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:53: (Reference<Primitive>
r) => r.definition).toList()));
I would add the extra argument here instead of at the tree generation.
This would allow for optimizations to work on the explicit structure.

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/tre...
File pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart (right):

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/tre...
pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart:526: Element getInterceptor =
backend.getInterceptorMethod;
I think we should go via Glue here.

https://codereview.chromium.org/806103003/diff/40001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/806103003/diff/40001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:21: import
'js_backend_cps_ir_interceptors.dart' as interceptors;
I think you forgot to add this test

[karlklose, 2014-12-16 12:04:03]

Thanks, Sigurd.

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right):

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:53: (Reference<Primitive>
r) => r.definition).toList()));
On 2014/12/16 11:44:55, sigurdm wrote:
> It would be nicer if you could just pass the arguments here. Maybe we should
> change the contructor, or add another constructor to InvokeMethod.

Done.

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:53: (Reference<Primitive>
r) => r.definition).toList()));
On 2014/12/16 11:44:56, sigurdm wrote:
> I would add the extra argument here instead of at the tree generation.
> This would allow for optimizations to work on the explicit structure.

Done.

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/tre...
File pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart (right):

https://codereview.chromium.org/806103003/diff/40001/pkg/compiler/lib/src/tre...
pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart:526: Element getInterceptor =
backend.getInterceptorMethod;
On 2014/12/16 11:44:56, sigurdm wrote:
> I think we should go via Glue here.

Done.

https://codereview.chromium.org/806103003/diff/40001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/806103003/diff/40001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:21: import
'js_backend_cps_ir_interceptors.dart' as interceptors;
On 2014/12/16 11:44:56, sigurdm wrote:
> I think you forgot to add this test

Done.

[sigurdm, 2014-12-16 12:16:14]

lgtm

[karlklose, 2014-12-16 12:29:18]

Committed patchset #7 (id:140001) manually as 42385 (presubmit successful).

[karlklose, 2014-12-16 13:23:55]

The unsugaring to JS semantics has problems with intercepted
getters/setters/..., since there are too many arguments. We may have to rewrite
the selectors for these calls.

[sigurdm, 2014-12-16 13:34:19]

lgtm

https://codereview.chromium.org/806103003/diff/160001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/806103003/diff/160001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:654: types.DartType
constantType = constant.getType(compiler.coreTypes);
Actually getType should probably also be delegated to Glue.

Does not have to be this CL.

[karlklose, 2014-12-16 13:48:25]

https://codereview.chromium.org/806103003/diff/160001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/806103003/diff/160001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:654: types.DartType
constantType = constant.getType(compiler.coreTypes);
On 2014/12/16 13:34:19, sigurdm wrote:
> Actually getType should probably also be delegated to Glue.
> 
> Does not have to be this CL.

Acknowledged.

[karlklose, 2014-12-16 13:48:36]

Committed patchset #8 (id:160001) manually as 42391 (presubmit successful).