Chromium Code Reviews

Issue 805393002: Update pub to use the new command runner API in args. (Closed)

Created:
6 years ago by nweiz
Modified:
5 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update pub to use the new command runner API in args. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=42885

Patch Set 1 #

Total comments: 10

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Stats (+1064 lines, -2168 lines)
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +2 lines, -191 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command.dart View 4 chunks +29 lines, -271 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/barback.dart View 6 chunks +14 lines, -16 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/build.dart View 2 chunks +5 lines, -4 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/cache.dart View 1 chunk +7 lines, -6 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/cache_add.dart View 2 chunks +15 lines, -15 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/cache_list.dart View 3 chunks +4 lines, -4 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/cache_repair.dart View 1 chunk +4 lines, -2 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/deps.dart View 2 chunks +6 lines, -4 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/downgrade.dart View 1 chunk +8 lines, -8 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/get.dart View 1 chunk +7 lines, -6 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/global.dart View 1 chunk +8 lines, -7 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/global_activate.dart View 3 chunks +18 lines, -18 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/global_deactivate.dart View 1 chunk +10 lines, -12 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/global_list.dart View 1 chunk +5 lines, -4 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/global_run.dart View 2 chunks +11 lines, -11 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command/help.dart View 1 chunk +0 lines, -54 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 3 chunks +12 lines, -10 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart View 1 chunk +5 lines, -3 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/run.dart View 2 chunks +12 lines, -12 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 3 chunks +17 lines, -16 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/upgrade.dart View 1 chunk +8 lines, -8 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 2 chunks +9 lines, -9 lines 0 comments
M sdk/lib/_internal/pub/lib/src/command/version.dart View 1 chunk +3 lines, -5 lines 0 comments
A sdk/lib/_internal/pub/lib/src/command_runner.dart View 1 chunk +182 lines, -0 lines 0 comments
M sdk/lib/_internal/pub/lib/src/exceptions.dart View 3 chunks +3 lines, -12 lines 0 comments
M sdk/lib/_internal/pub/lib/src/log.dart View 1 chunk +1 line, -0 lines 0 comments
M sdk/lib/_internal/pub/lib/src/system_cache.dart View 2 chunks +15 lines, -2 lines 0 comments
M sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/cache/add/missing_package_arg_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/cache/add/unexpected_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/global/deactivate/missing_package_arg_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/global/deactivate/unexpected_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/global/run/missing_executable_arg_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/lish/force_cannot_be_combined_with_dry_run_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/package_list_files_test.dart View 1 chunk +2 lines, -1 line 0 comments
M sdk/lib/_internal/pub/test/pub_test.dart View 2 chunks +19 lines, -318 lines 0 comments
M sdk/lib/_internal/pub/test/pub_uploader_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/run/errors_if_no_executable_is_given_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/run/errors_if_path_in_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/test_pub.dart View 1 chunk +2 lines, -1 line 0 comments
M sdk/lib/_internal/pub_generated/bin/pub.dart View 1 chunk +2 lines, -283 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command.dart View 4 chunks +30 lines, -287 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/barback.dart View 6 chunks +15 lines, -16 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/build.dart View 2 chunks +5 lines, -4 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/cache.dart View 1 chunk +7 lines, -6 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/cache_add.dart View 2 chunks +15 lines, -15 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/cache_list.dart View 3 chunks +4 lines, -4 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/cache_repair.dart View 1 chunk +4 lines, -2 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/deps.dart View 3 chunks +6 lines, -4 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/downgrade.dart View 1 chunk +8 lines, -8 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/get.dart View 1 chunk +7 lines, -6 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/global.dart View 1 chunk +8 lines, -7 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/global_activate.dart View 3 chunks +18 lines, -18 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/global_deactivate.dart View 1 chunk +10 lines, -12 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/global_list.dart View 1 chunk +5 lines, -4 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/global_run.dart View 3 chunks +11 lines, -11 lines 0 comments
D sdk/lib/_internal/pub_generated/lib/src/command/help.dart View 1 chunk +0 lines, -55 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/lish.dart View 3 chunks +12 lines, -10 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/list_package_dirs.dart View 1 chunk +5 lines, -3 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/run.dart View 4 chunks +12 lines, -12 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/serve.dart View 5 chunks +17 lines, -16 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/upgrade.dart View 1 chunk +8 lines, -8 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/uploader.dart View 2 chunks +9 lines, -9 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/command/version.dart View 1 chunk +3 lines, -5 lines 0 comments
A sdk/lib/_internal/pub_generated/lib/src/command_runner.dart View 1 chunk +336 lines, -0 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/exceptions.dart View 3 chunks +3 lines, -12 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/log.dart View 1 chunk +1 line, -0 lines 0 comments
M sdk/lib/_internal/pub_generated/lib/src/system_cache.dart View 2 chunks +15 lines, -2 lines 0 comments
M sdk/lib/_internal/pub_generated/test/cache/add/bad_version_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/cache/add/missing_package_arg_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/cache/add/unexpected_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/global/deactivate/missing_package_arg_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/global/deactivate/unexpected_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/global/run/errors_if_outside_bin_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/global/run/missing_executable_arg_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/lish/force_cannot_be_combined_with_dry_run_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/package_list_files_test.dart View 1 chunk +2 lines, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/pub_test.dart View 2 chunks +19 lines, -295 lines 0 comments
M sdk/lib/_internal/pub_generated/test/pub_uploader_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/run/errors_if_no_executable_is_given_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/run/errors_if_path_in_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub_generated/test/test_pub.dart View 1 chunk +2 lines, -1 line 0 comments

Messages

Total messages: 6 (0 generated)
nweiz
6 years ago (2014-12-17 00:52:13 UTC) #1
Bob Nystrom
https://codereview.chromium.org/805393002/diff/1/sdk/lib/_internal/pub/lib/src/command.dart File sdk/lib/_internal/pub/lib/src/command.dart (right): https://codereview.chromium.org/805393002/diff/1/sdk/lib/_internal/pub/lib/src/command.dart#newcode80 sdk/lib/_internal/pub/lib/src/command.dart:80: PubCommand(); Delete. https://codereview.chromium.org/805393002/diff/1/sdk/lib/_internal/pub/lib/src/command/build.dart File sdk/lib/_internal/pub/lib/src/command/build.dart (right): https://codereview.chromium.org/805393002/diff/1/sdk/lib/_internal/pub/lib/src/command/build.dart#newcode25 sdk/lib/_internal/pub/lib/src/command/build.dart:25: String ...
5 years, 11 months ago (2015-01-05 20:45:28 UTC) #2
nweiz
Code review changes
5 years, 11 months ago (2015-01-14 20:39:05 UTC) #3
nweiz
https://codereview.chromium.org/805393002/diff/1/sdk/lib/_internal/pub/lib/src/command.dart File sdk/lib/_internal/pub/lib/src/command.dart (right): https://codereview.chromium.org/805393002/diff/1/sdk/lib/_internal/pub/lib/src/command.dart#newcode80 sdk/lib/_internal/pub/lib/src/command.dart:80: PubCommand(); On 2015/01/05 20:45:27, Bob Nystrom wrote: > Delete. ...
5 years, 11 months ago (2015-01-14 20:39:37 UTC) #4
Bob Nystrom
lgtm
5 years, 11 months ago (2015-01-14 20:52:26 UTC) #5
nweiz
5 years, 11 months ago (2015-01-14 21:28:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42885 (presubmit successful).

Powered by Google App Engine