Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 804903004: Refactor LibraryUpdater to prepare for parts. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, lukechurch, kasperl
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Refactor LibraryUpdater to prepare for parts. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42384

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Call super.incrementalCompiler setter. #

Patch Set 3 : Merged with r42383. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -63 lines) Patch
M dart/pkg/dart2js_incremental/lib/dart2js_incremental.dart View 4 chunks +6 lines, -2 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 6 chunks +93 lines, -55 lines 0 comments Download
M dart/site/try/poi/poi.dart View 5 chunks +7 lines, -3 lines 0 comments Download
M dart/tests/try/poi/apply_updates_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M dart/tests/try/poi/library_updater_test.dart View 2 chunks +4 lines, -1 line 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
6 years ago (2014-12-15 12:33:50 UTC) #3
ahe
ping
6 years ago (2014-12-16 10:44:58 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/804903004/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/804903004/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode125 dart/pkg/dart2js_incremental/lib/library_updater.dart:125: } You need to do super.incrementalCompiler = value;
6 years ago (2014-12-16 11:22:52 UTC) #5
ahe
Thank you, Johnni! https://codereview.chromium.org/804903004/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/804903004/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode125 dart/pkg/dart2js_incremental/lib/library_updater.dart:125: } On 2014/12/16 11:22:52, Johnni Winther ...
6 years ago (2014-12-16 12:04:31 UTC) #6
ahe
6 years ago (2014-12-16 12:13:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as 42384 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698