Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 804333002: Add CoreTypes interface. (Closed)

Created:
6 years ago by Johnni Winther
Modified:
6 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -79 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 8 chunks +11 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 6 chunks +93 lines, -32 lines 2 comments Download
M pkg/compiler/lib/src/constants/values.dart View 13 chunks +17 lines, -26 lines 0 comments Download
A pkg/compiler/lib/src/core_types.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years ago (2014-12-16 08:21:36 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/804333002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/804333002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1375 pkg/compiler/lib/src/compiler.dart:1375: _coreTypes.objectClass = lookupCoreClass('Object'); Would it be possible to ...
6 years ago (2014-12-16 09:04:38 UTC) #3
Johnni Winther
https://codereview.chromium.org/804333002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/804333002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1375 pkg/compiler/lib/src/compiler.dart:1375: _coreTypes.objectClass = lookupCoreClass('Object'); On 2014/12/16 09:04:38, karlklose wrote: > ...
6 years ago (2014-12-16 10:21:01 UTC) #4
Johnni Winther
6 years ago (2014-12-16 10:27:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 42382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698