Issue 804193004: Fix error in csp output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804193004: Fix error in csp output. (Closed)

Created:
5 years, 11 months ago by zarah

Modified:
5 years, 11 months ago

Reviewers:
Johnni Winther, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix error in csp output. Committed: https://code.google.com/p/dart/source/detail?r=42586

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zarah

Committed patchset #1 (id:1) manually as 42586 (presubmit successful).

5 years, 11 months ago (2015-01-05 10:55:42 UTC) #1

Johnni Winther

lgtm https://codereview.chromium.org/804193004/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart (right): https://codereview.chromium.org/804193004/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart#newcode370 pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:370: var constructors = dart_precompiled(processedClasses.collected); Why do we need ...

5 years, 11 months ago (2015-01-05 11:23:57 UTC) #4

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages