Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 80393003: Remove hack on typed array length fully: previous CL just removed the length access, not setting th… (Closed)

Created:
7 years, 1 month ago by ngeoffray
Modified:
7 years, 1 month ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, sra1, kasperl
Visibility:
Public.

Description

Remove hack on typed array length fully: previous CL just removed the length access, not setting the extra field. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=30497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -66 lines) Patch
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 11 chunks +38 lines, -66 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 1 month ago (2013-11-21 07:48:35 UTC) #1
karlklose
LGTM.
7 years, 1 month ago (2013-11-21 07:54:23 UTC) #2
ngeoffray
7 years, 1 month ago (2013-11-21 08:00:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698