Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 803913003: fix named constructor completion (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

fix named constructor completion BUG=dartbug.com/21799 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42365

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 2 chunks +18 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 6 chunks +6 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +61 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years ago (2014-12-15 03:27:29 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/803913003/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart File pkg/analysis_server/test/services/completion/completion_test_util.dart (right): https://codereview.chromium.org/803913003/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart#newcode1029 pkg/analysis_server/test/services/completion/completion_test_util.dart:1029: //assertSuggestImportedClass('D', CompletionRelevance.LOW) Was the semicolon removed by mistake?
6 years ago (2014-12-15 16:27:30 UTC) #3
danrubel
Committed patchset #1 (id:1) manually as 42365 (presubmit successful).
6 years ago (2014-12-15 17:16:47 UTC) #4
danrubel
6 years ago (2014-12-15 17:18:31 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/803913003/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/completion/completion_test_util.dart
(right):

https://codereview.chromium.org/803913003/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/completion/completion_test_util.dart:1029:
//assertSuggestImportedClass('D', CompletionRelevance.LOW)
On 2014/12/15 16:27:30, Paul Berry wrote:
> Was the semicolon removed by mistake?

Yes. Will add back in following CL

Powered by Google App Engine
This is Rietveld 408576698