Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 803543002: Resolve libraries against their canonical URI. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Resolve libraries against their canonical URI. This is fixes a regression from r10895. BUG=https://code.google.com/p/dart/issues/detail?id=21864 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42359

Patch Set 1 : #

Patch Set 2 : Merged with r42358. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -33 lines) Patch
M dart/pkg/compiler/lib/src/apiimpl.dart View 5 chunks +9 lines, -4 lines 0 comments Download
M dart/pkg/compiler/lib/src/library_loader.dart View 3 chunks +3 lines, -19 lines 0 comments Download
M dart/pkg/compiler/lib/src/scanner/scanner_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/interceptors.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/isolate_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/js_names.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/libraries.dart View 1 chunk +19 lines, -1 line 0 comments Download
M dart/sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A dart/tests/compiler/dart2js/library_resolution_test.dart View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
ahe
6 years ago (2014-12-15 10:17:48 UTC) #5
Johnni Winther
lgtm
6 years ago (2014-12-15 11:14:15 UTC) #6
ahe
6 years ago (2014-12-15 11:46:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as 42359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698