Issue 803103004: Revert "dart2js: put all type-test related properties on the prototype and not on the constructor."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 803103004: Revert "dart2js: put all type-test related properties on the prototype and not on the constructor." (Closed)

Created:
6 years ago by floitsch

Modified:
6 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "dart2js: put all type-test related properties on the prototype and not on the constructor." This reverts commit r42392. Committed: https://code.google.com/p/dart/source/detail?r=42408

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -59 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart	View	6 chunks	+63 lines, -34 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_rti.dart	View	4 chunks	+20 lines, -23 lines	0 comments	Download
M	tests/compiler/dart2js/deferred_emit_type_checks_test.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

floitsch

TBR. when accessing new P.Object().constructor things go wrong and we don't find the correct prototype.

6 years ago (2014-12-16 20:02:12 UTC) #2

floitsch

Committed patchset #1 (id:1) manually as 42408 (presubmit successful).

6 years ago (2014-12-16 20:02:30 UTC) #3

Message was sent while issue was closed.

LGTM.