Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802603002: Simplify _FrozenElementList (Closed)

Created:
6 years ago by sra1
Modified:
6 years ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Simplify _FrozenElementList There is no need to filter the NodeList since it can contain only Elements. R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=42306

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -56 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +11 lines, -18 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +13 lines, -20 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
6 years ago (2014-12-12 01:07:14 UTC) #2
Jacob
lgtm https://codereview.chromium.org/802603002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/802603002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode256 tools/dom/templates/html/impl/impl_Element.darttemplate:256: // Wrapper over an immutable NodeList to make ...
6 years ago (2014-12-12 01:11:23 UTC) #3
sra1
6 years ago (2014-12-12 01:40:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698