Move notification of isolate creation until after the ObjectStore is initialized.

Move notification of isolate creation until after the ObjectStore is initialized.

The debugger_ is initialized in Dart::CreateIsolate but the object
store is only valid after Dart::InitializeIsolate.  I could have moved
the initalization of debugger_ later, but then many of the debugger()
accesses in the vm would need null checks.  Instead I moved the
isolate creation notification a bit.

I was only able to see this problem when running a two isolate program
with the --pause-isolates-on-start option.

BUG=
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42344

[turnidge, 2014-12-11 20:34:52]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2014-12-11 23:47:01]

lgtm with nits

https://codereview.chromium.org/802543002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/802543002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18330: (Isolate::Current()->object_store() != NULL &&
Parens around Isolate::Current()->object_store() != NULL

https://codereview.chromium.org/802543002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18331:
Isolate::Current()->object_store()->one_byte_string_class() !=
Parens around Isolate::Current()->object_store()->one_byte_string_class() !=
Class::null()

[turnidge, 2014-12-12 17:48:29]

https://codereview.chromium.org/802543002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/802543002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18330: (Isolate::Current()->object_store() != NULL &&
On 2014/12/11 23:47:01, Cutch wrote:
> Parens around Isolate::Current()->object_store() != NULL

Done.

https://codereview.chromium.org/802543002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18331:
Isolate::Current()->object_store()->one_byte_string_class() !=
On 2014/12/11 23:47:01, Cutch wrote:
> Parens around Isolate::Current()->object_store()->one_byte_string_class() !=
> Class::null()

Done.

[turnidge, 2014-12-12 20:21:32]

Committed patchset #2 (id:20001) manually as 42344 (presubmit successful).